Do not guess if a string is already hex encoded #216
Conversation
Also, skip flake8 tests in several unnecessary folders
|
So I rebuilt my tox and the error started reproducing locally. There are a few libraries that changed between this and a recent successful:
Since the primary error is coming from an internal pytest plugin, I'm guessing it's the pytest upgrade. Investigating further... |
|
Confirmed that tox run is successful again after forcing pytest back to 3.1.3 (except the flake8 issue) |
|
Yup, 3.2.0 bug. Will be fixed in 3.2.1
|
@see pytest-dev/pytest#2644 No need to revert this when 3.2.1 is released, because it provides a cleaner view in the pytest output
| @@ -28,7 +28,9 @@ | |||
| '0xbb9bc244d798123fde783fcc1c72d3bb8c189413', | |||
| ], | |||
| ), | |||
| ) | |||
| ), | |||
| ids=['nullbyte', 'soloaddr', 'addrlist'] | |||
There was a problem hiding this comment.
Assuming this is the fix for pytest 3.2, I think I'd rather just pin the dependency to pytest<3.2.0 with a comment linking to the issue in the pytest repo.
There was a problem hiding this comment.
Yes, it fixes the pytest issue, but it also makes the pytest output somewhat more readable:
tests/contracts/test_normalization_of_return_types.py::test_normalizing_return_values[nullbyte] PASSED
tests/contracts/test_normalization_of_return_types.py::test_normalizing_return_values[soloaddr] PASSED
tests/contracts/test_normalization_of_return_types.py::test_normalizing_return_values[addrlist] PASSED
But I'm only mildly in favor of this approach. If you are more worried about consistency between tests than test output readability for this test, I'm happy to go the version pinning route.
There was a problem hiding this comment.
I'm convinced. feel free to leave this in.
I don't know flake8 all that well, but clearly the intention was to ignore py3 syntax errors here, and it does that now. Plus, it's python2-only, so I didn't care enough to investigate further
Also, skip flake8 tests in several unnecessary folders. This significantly sped up my local
flake8andtoxrun.What was wrong?
See issue #215
How was it fixed?
Stop inspecting the string for a leading '0x'
Cute Animal Picture