Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.7: #3195

Closed
wants to merge 0 commits into from

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Jan 20, 2024

What was wrong?

We will have more peripheral updates to make due to the dropping of python 3.7, such as forgoing some typing imports from typing_extensions, etc. For now, we have PRs that are already expecting python 3.7 to be dropped and all tests fail there.

closes #3032

How was it fixed?

Drop the tests + CI support for py37 and the claim that the library supports 3.7.2 and above.

Todo:

Cute Animal Picture

20240122_115542

@fselmo fselmo marked this pull request as ready for review January 20, 2024 00:58
@fselmo fselmo requested review from kclowes, reedsa and pacrob January 22, 2024 18:55
fselmo added a commit to fselmo/web3.py that referenced this pull request Jan 22, 2024
@fselmo fselmo force-pushed the drop-support-for-py37 branch from a625da6 to 8b004b4 Compare January 22, 2024 18:58
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more references I noticed that may need to be removed.
Looks like there's a brief mention of 3.7 in the README.md.
I also see a docker config using python 3.7.

@fselmo
Copy link
Collaborator Author

fselmo commented Jan 22, 2024

A couple more references I noticed that may need to be removed. Looks like there's a brief mention of 3.7 in the README.md. I also see a docker config using python 3.7.

I'm not seeing these, can you link the references in the github code?

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@pacrob
Copy link
Contributor

pacrob commented Jan 22, 2024

I see a few more conditionals that can go:

  • ens/_normalization.py:29
  • tests/core/eth-module/test_accounts.py:469, 481
  • tests/core/middleware/test_stalecheck.py:143
  • tests/core/providers/test_websocket_provider.py:24

@fselmo
Copy link
Collaborator Author

fselmo commented Jan 22, 2024

I see a few more conditionals that can go:

I was going to leave some of the deep-dive peripheral stuff related to dropping python 3.7 and just drop the support for it atm. But since you've highlighted these I can add them in here. There may be some others that we find along the way as well. I'll do a quick search for more as well.

@pacrob pacrob closed this Jan 22, 2024
@pacrob pacrob force-pushed the drop-support-for-py37 branch from 578c8cb to 84609c3 Compare January 22, 2024 21:55
@fselmo fselmo mentioned this pull request Jan 22, 2024
fselmo added a commit to fselmo/web3.py that referenced this pull request Jan 22, 2024
fselmo added a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.7
4 participants