-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for python 3.7: #3195
Conversation
a625da6
to
8b004b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more references I noticed that may need to be removed.
Looks like there's a brief mention of 3.7 in the README.md.
I also see a docker config using python 3.7.
I'm not seeing these, can you link the references in the github code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
I see a few more conditionals that can go:
|
I was going to leave some of the deep-dive peripheral stuff related to dropping python 3.7 and just drop the support for it atm. But since you've highlighted these I can add them in here. There may be some others that we find along the way as well. I'll do a quick search for more as well. |
578c8cb
to
84609c3
Compare
What was wrong?
We will have more peripheral updates to make due to the dropping of python 3.7, such as forgoing some typing imports from typing_extensions, etc. For now, we have PRs that are already expecting python 3.7 to be dropped and all tests fail there.
closes #3032
How was it fixed?
Drop the tests + CI support for py37 and the claim that the library supports 3.7.2 and above.
Todo:
Cute Animal Picture