This repository was archived by the owner on Aug 2, 2021. It is now read-only.
Change storage Proximity function #1079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
|
we said we want no migration or db repair with this fix for now until the new db is in place. |
|
Submitted upstream ethereum/go-ethereum#18379. |
|
merged upstream ethereum#18379. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes Proximity function in storage package to successfully pass all test cases in a newly added TestProximity function. Current Proximity function returns MaxPO value for MaxPO-9 to MaxPO-1 (last 8 bins of MaxPO bins, or last byte) instead lower values.
For example, for MaxPO=16 the test will fail with incorrect values for bins 8-15 with value 16 for all of them, and for MaxPO=32 bins 24-31 will have value of 32.