Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparision of null values to allow null values in enum schemas #127

Closed
wants to merge 1 commit into from
Closed

Comparision of null values to allow null values in enum schemas #127

wants to merge 1 commit into from

Conversation

heneke
Copy link

@heneke heneke commented Dec 17, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 91.908% when pulling 037e3e8 on heneke:enum_null_value into 57052ce on everit-org:master.

@erosb
Copy link
Contributor

erosb commented Dec 17, 2017

Hi! I've just pushed an other fix of #126 into master : 60cbcca .

I find it a bit more appropriate than yours (bit more tests and a bit better place for the fix), although this PR would also be sufficient.

I'm closing this PR. Do you need an urgent release with this fix? If you don't need any specific release number then you can just use the fixed version by referring to the commit hash of the fix:

        <dependency>
            <groupId>com.github.everit-org.json-schema</groupId>
            <artifactId>org.everit.json.schema</artifactId>
            <version>60cbcca1887949f5935b6989d5a579746330cc2f</version>
        </dependency>

@erosb erosb closed this Dec 17, 2017
@heneke
Copy link
Author

heneke commented Dec 18, 2017

No offense taken – you know the codebase way better than me.

@heneke heneke deleted the enum_null_value branch December 18, 2017 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants