Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace foreach clauses in Parquet readers with loops #26

Closed
morazow opened this issue Aug 30, 2021 · 0 comments · Fixed by #27
Closed

Replace foreach clauses in Parquet readers with loops #26

morazow opened this issue Aug 30, 2021 · 0 comments · Fixed by #27
Labels
refactoring Code improvement without behavior change

Comments

@morazow
Copy link
Contributor

morazow commented Aug 30, 2021

Situation

There are couple of foreach iterations when reading Parquet values. We should replace them with loops, since foreach add more overhead than necessary.

Acceptance Criteria

  • Replaced foreach iterations with loops
@morazow morazow added refactoring Code improvement without behavior change source:exasol labels Aug 30, 2021
morazow added a commit that referenced this issue Sep 1, 2021
@morazow
Replaced foreachs with loop iteration
629d66c 
Fixes #26
@morazow morazow mentioned this issue Sep 1, 2021
Merged
morazow added a commit that referenced this issue Sep 1, 2021
@morazow
#26: Replaced foreachs with loop iteration (#27)
f874935 
Fixes #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#26: Replaced foreachs with loop iteration exasol/parquet-io-java
1 participant
@morazow