-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#19: Add project-keeper #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice!
Added minor suggestions, overall looks good.
dependencies.md
Outdated
[33]: https://maven.apache.org/enforcer/maven-enforcer-plugin/ | ||
[10]: https://github.com/mockito/mockito/blob/release/3.x/LICENSE | ||
[8]: https://www.eclipse.org/legal/epl-v20.html | ||
[3]: https://github.com/google/guava | ||
[59]: http://maven.apache.org/plugins/maven-install-plugin/ | ||
[3]: https://github.com/google/guava/guava |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this fails with link checker. This Guava link is somehow wrong from dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I created a PR: google/guava#5619
pom.xml
Outdated
</modules> | ||
<excludedPlugins> | ||
<!-- does not work with scalar code yet --> | ||
<excludedPlugin>com.exasol:error-code-crawler</excludedPlugin> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
pom.xml
Outdated
@@ -480,7 +491,6 @@ | |||
<serialwarn>true</serialwarn> | |||
<failOnError>true</failOnError> | |||
<failOnWarnings>true</failOnWarnings> | |||
<sourcepath>${project.basedir}/src/main/java</sourcepath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also causes Javadoc to fail.
Co-authored-by: Muhammet Orazov <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
Closes #19