Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19: Add project-keeper #20

Merged
merged 6 commits into from
Jun 23, 2021
Merged

#19: Add project-keeper #20

merged 6 commits into from
Jun 23, 2021

Conversation

jakobbraun
Copy link
Contributor

Closes #19

@jakobbraun jakobbraun added the refactoring Code improvement without behavior change label Jun 21, 2021
@jakobbraun jakobbraun requested a review from morazow June 21, 2021 07:05
@jakobbraun jakobbraun self-assigned this Jun 21, 2021
Copy link
Contributor

@morazow morazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice!
Added minor suggestions, overall looks good.

dependencies.md Outdated
[33]: https://maven.apache.org/enforcer/maven-enforcer-plugin/
[10]: https://github.com/mockito/mockito/blob/release/3.x/LICENSE
[8]: https://www.eclipse.org/legal/epl-v20.html
[3]: https://github.com/google/guava
[59]: http://maven.apache.org/plugins/maven-install-plugin/
[3]: https://github.com/google/guava/guava
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fails with link checker. This Guava link is somehow wrong from dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I created a PR: google/guava#5619

pom.xml Outdated
</modules>
<excludedPlugins>
<!-- does not work with scalar code yet -->
<excludedPlugin>com.exasol:error-code-crawler</excludedPlugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pom.xml Outdated
@@ -480,7 +491,6 @@
<serialwarn>true</serialwarn>
<failOnError>true</failOnError>
<failOnWarnings>true</failOnWarnings>
<sourcepath>${project.basedir}/src/main/java</sourcepath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also causes Javadoc to fail.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jakobbraun jakobbraun merged commit 9f7c577 into main Jun 23, 2021
@jakobbraun jakobbraun deleted the refactor/19-project-keeper branch June 23, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add project-keeper
2 participants