-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#30: Added sorting and merging of overlapping chunks to be safe #31
Conversation
src/main/java/com/exasol/parquetio/merger/ChunkIntervalMerger.java
Outdated
Show resolved
Hide resolved
src/main/java/com/exasol/parquetio/merger/ChunkIntervalMerger.java
Outdated
Show resolved
Hide resolved
src/test/java/com/exasol/parquetio/merger/ChunkIntervalMergerTest.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
* @return a list of sorted and merged chunks | ||
*/ | ||
public List<ChunkInterval> sortAndMerge(final List<ChunkInterval> chunks) { | ||
if (chunks == null || chunks.size() <= 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
||
// [utest->dsn~read-parquet-file-chunks-contents~1] | ||
class RowParquetChunkReaderTest { | ||
|
||
private static final int RECORD_COUNT = 200000; | ||
|
||
@ParameterizedTest | ||
@NullAndEmptySource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know this. Very helpful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, definitely, I also found it accidentally while reading on ValueSource :)
Fixes #30.