Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the changes from #716 adding the
max_completion_tokens
property to the ChatGPT API'sChatCompletionRequest
in alignment with the OpenAI API spec. This is used to provide a client defined limit on the maximum number of tokens returned from inference, as long as this is less than thenode.max_generate_tokens
specified on the command line. This supports both the newmax_completion_tokens
and the oldermax_tokens
option if the former is not present.The main structural change in this PR is the addition of the
GenerationOptions
parameter to theSendPrompt
andSendTensor
grpc methods and the methods which they call. This allows for request specific options during inference. I kept this separate from the existingInferenceState
as this seemed focused on stable diffusion specific data which could change over the course of inference.If any more changes are made to the parent PR I will rebase this PR to match.