Setting up weasel branch #12456
Merged
Setting up weasel branch #12456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianeboyd
reviewed
Mar 23, 2023
|
@adrianeboyd & @bdura : this is now ready for review :-) |
bdura
reviewed
Mar 27, 2023
bdura
approved these changes
Mar 28, 2023
svlandeg
added a commit
that referenced
this pull request
Jul 7, 2023
* Setting up weasel branch (#12456) * remove project-specific functionality * remove project-specific tests * remove project-specific schemas * remove project-specific information in about * remove project-specific functions in util.py * remove project-specific error strings * remove project-specific CLI commands * black formatting * restore some functions that are used beyond projects * remove project imports * remove imports * remove remote_storage tests * remove one more project unit test * update for PR 12394 * remove get_hash and get_checksum * remove upload_ and download_file methods * remove ensure_pathy * revert clumsy fingers * reinstate E970 * feat: use weasel as spacy project command (#12473) * feat: use weasel as spacy project command * build: use constrained requirement for weasel * feat: add weasel to the library requirements * build: update weasel to new version * build: use specific weasel tag * build: use weasel-0.1.0rc1 from PyPI * fix: remove weasel from requirements.txt * fix: requirements.txt and setup.cfg need to reflect each other * feat: remove legacy spacy project code * bump version * further merge fixes * isort --------- Co-authored-by: Basile Dura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting up the
weaselbranch to coordinate migration ofspacy projectstoweasel.The functionality of this PR accompanies explosion/weasel#9 and explosion/weasel#11.
In a nutshell, we've moved all project-related functionality & tests verbatim to
weasel. The big exception are the projects tests intest_cli_app.py- those remain and will be fixed in follow up PRs to theexplosion:feature/weaselbranch, as we still wantpython -m spacy projectsto work exactly as before.Types of change
WIP - migration
Checklist
The test might just fail right now, that's OK. We're not merging this into
master, just into a specific feature branch to continue working on. Specifically, the ones intest_cli_app.pywill fail right now.