Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpanFinder: set default max_length to 25 #12791

Conversation

adrianeboyd
Copy link
Contributor

Description

When the default max_length is not set and there are longer training documents, it can be difficult to train and evaluate the span finder due to memory limits and the time it takes to evaluate a huge number of predicted spans.

Types of change

Enhancement.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

When the default `max_length` is not set and there are longer training
documents, it can be difficult to train and evaluate the span finder due
to memory limits and the time it takes to evaluate a huge number of
predicted spans.
@adrianeboyd adrianeboyd added enhancement Feature requests and improvements feat / spanfinder Feature: Span Finder labels Jul 6, 2023
@svlandeg svlandeg merged commit 830dcca into explosion:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / spanfinder Feature: Span Finder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants