Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial cleanup of 5.x alpha doc #1050

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Initial cleanup of 5.x alpha doc #1050

merged 1 commit into from
Jul 3, 2019

Conversation

crandmck
Copy link
Member

After landing #1037 this PR takes care of some housekeeping and clean-up, specifically:

  • Add changes for 4.17 release that were in 4.17 API documentation #1043
  • Adds an announcement to the home page about the 5.x alpha docs, as discussed in the last @expressjs/express-tc meeting.
  • Adds a short disclaimer to the top of the API page saying the docs are a work in progress.
  • Removes several notices stating This middleware is available in Express v4.xx.0 onwards; I'm assuming these notes are irrelevant in the 5.x docs (since the middleware will be available in 5.x). Please correct me if I'm mistaken.
  • Changes all the cross-references within the 5.x API docs from 4.x to the new 5.x docs. In general for a given major release we should keep the cross-references within that release's API doc. IOW, the links that were to /en/4x/api.html#xyz were changed to /en/5x/api.html#xyz.

@crandmck crandmck merged commit 4acf359 into gh-pages Jul 3, 2019
@crandmck crandmck deleted the 5x-initial-cleanup branch July 8, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant