Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes msys2 dependency #117

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Conversation

Ilia-Kosenkov
Copy link
Member

Closes #91.
I have verified this behavior twice:

  • Using a VBox Windows 10 VM with VC++ Build Tools, Rust/Cargo, R-4.1.0 and Rtools40v2 (clean installation, no msys2 on the system)
  • Using the same CI with reset cache, check the output here
    I used an example by @yutannihilation posted in msys2 is no longer needed on Windows? #91, where the path was forced to point only to R and cargo binaries and rtools.
    Under these conditions, the CI successfully executes devtools::test(), which means the Rust code is indeed compiled successfully.

This can be separately verified by any Windows user by purging msys2 (or removing it from PATH) and then running something like rextendr::rust_eval("5i32 + 10i32").

@Ilia-Kosenkov Ilia-Kosenkov added the enhancement New feature or request label Jun 8, 2021
@Ilia-Kosenkov Ilia-Kosenkov merged commit 6cbe1ab into extendr:main Jun 8, 2021
@Ilia-Kosenkov Ilia-Kosenkov deleted the no-msys2 branch April 20, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msys2 is no longer needed on Windows?
2 participants