Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'toolchain' parameter to control rust builds #20

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

Ilia-Kosenkov
Copy link
Member

Fixes #19.
toolchain parameter allows overriding default toolchain used system-wide when building rust libraries.
In most cases, the default toolchain is the preferred choice, but on Windows default toolchain can be *-msvc, which requires MSYS2 installed for linking. In such a scenario, toolchain allows using *-gnu to compile rextendr chunks without overriding system default.

@clauswilke clauswilke merged commit 80380a7 into extendr:main Jan 12, 2021
@clauswilke
Copy link
Member

Thanks!

Ilia-Kosenkov added a commit to Ilia-Kosenkov/rextendr that referenced this pull request Jan 14, 2021
* 'toolchain' parameter

* Documentation

* Tooltip clarification
@Ilia-Kosenkov Ilia-Kosenkov deleted the windows-toolchain branch December 12, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Windows, default rust needs to be gnu, not msvc
2 participants