Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url field in pkgdown config #413

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

etiennebacher
Copy link
Contributor

@etiennebacher etiennebacher commented Feb 10, 2025

Currently, being on https://extendr.github.io/rextendr/, searching "source" (for example) and clicking on the first result in "Reference" gives a 404. This is because the URL is https://extendr.github.io/reference/make_module_macro.html?q=source (missing rextendr at the beginning).

I think using the url field should fix that.

@Ilia-Kosenkov
Copy link
Member

Alright let's test this

@Ilia-Kosenkov Ilia-Kosenkov merged commit cbd93f6 into extendr:main Feb 10, 2025
19 checks passed
@etiennebacher etiennebacher deleted the patch-1 branch February 10, 2025 17:10
@etiennebacher
Copy link
Contributor Author

Seems to work, the same procedure described above (starting from https://extendr.github.io/rextendr/dev/) doesn't lead to 404 anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants