Replace deprecated distutils #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #255 and #263, replacing the unprotected uses of distutils. (There is one more occurrence in
build_tools/build.py, but that is only a fallback.)The patch to
pydev_ipython/inputhook.py(which currently usesLooseVersion) requires importingpackaging. However, I would suggest that a better patch is to drop the version check entirely. The changelog at https://github.com/wxWidgets/Phoenix/blob/master/CHANGES.rst says thatwxPythonversion 2.8.0.1 was released in December 2006. The chances of someone using aPyDev.Debuggerversion from 2025 together with awxPythonfrom 2006 or earlier is so remote that the check is pointless.Best wishes,
Julian