Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proximity Mode #135

Merged
merged 1 commit into from
Oct 27, 2019
Merged

Proximity Mode #135

merged 1 commit into from
Oct 27, 2019

Conversation

fabricepipart
Copy link
Owner

Fixes #91

@codecov-io
Copy link

codecov-io commented Oct 19, 2019

Codecov Report

Merging #135 into master will increase coverage by 1.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   80.94%   82.03%   +1.08%     
==========================================
  Files          86       87       +1     
  Lines        2404     2427      +23     
  Branches      195      191       -4     
==========================================
+ Hits         1946     1991      +45     
+ Misses        395      374      -21     
+ Partials       63       62       -1
Flag Coverage Δ
#javaserver 85.28% <100%> (+1.19%) ⬆️
#pythonclient 72.27% <100%> (+1.45%) ⬆️
Impacted Files Coverage Δ
.../trd/app/teknichrono/model/dto/NestedPilotDTO.java 100% <ø> (+93.33%) ⬆️
src/main/client/ping_selectors/select_high.py 100% <ø> (ø) ⬆️
...a/org/trd/app/teknichrono/model/dto/DtoMapper.java 100% <ø> (ø) ⬆️
src/main/client/datamodel/chrono_synchronizer.py 95.5% <ø> (-2.17%) ⬇️
.../trd/app/teknichrono/model/dto/ChronometerDTO.java 100% <ø> (ø) ⬆️
src/main/client/ping_selectors/select_proximity.py 100% <100%> (ø)
...d/app/teknichrono/business/client/PingManager.java 97.45% <100%> (+0.06%) ⬆️
src/main/client/ping_selectors/factory.py 100% <100%> (ø) ⬆️
...ava/org/trd/app/teknichrono/rest/PingEndpoint.java 91.89% <100%> (+2.6%) ⬆️
...p/teknichrono/model/repository/PingRepository.java 100% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 524031b...2384a9a. Read the comment docs.

@fabricepipart fabricepipart force-pushed the feature/proximity branch 8 times, most recently from 6a65d0f to e58b24c Compare October 24, 2019 05:58
@fabricepipart fabricepipart force-pushed the feature/proximity branch 12 times, most recently from 2835123 to 4af0c67 Compare October 27, 2019 18:10
@fabricepipart fabricepipart merged commit 4f5fa10 into master Oct 27, 2019
@fabricepipart fabricepipart deleted the feature/proximity branch October 27, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an admin, I should be able to put a chrono in Proximity mode so that it reports the closest Beacon
2 participants