Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(v2): fork clean-webpack-plugin to reduce memory #1839

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Oct 14, 2019

Motivation

Really fix #1782

So we need to fork because

  • We want v2 of clean-webpack-plugin that use webpack compile hook, unlike its v3 that uses emit hook. Using upstream clean-webpack-plugin will break our SSR setup and fail our build
  • Reduce memory usage of clean-webpack-plugin by skipping resource heavy webpack stats. FYI i sent PR for them too but its for their v3

This is non-destructive.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan


Edit @slorber: referencing useful links/discussions

@endiliey endiliey requested a review from yangshun as a code owner October 14, 2019 12:33
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 14, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 84da1c1

https://deploy-preview-1839--docusaurus-2.netlify.com

@endiliey endiliey merged commit bdb1292 into master Oct 14, 2019
@endiliey endiliey deleted the endi/clean-webpack branch October 14, 2019 12:37
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 84da1c1

https://deploy-preview-1839--docusaurus-preview.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] yarn build crashes out of memory after 92% for huge files
3 participants