-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(website): use react-lite-youtube-embed for lazy YouTube video #7390
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another video on /docs/
as well. Could you take some time to migrate that?
@matkoch Besides the change requested above, I need to make some refactors as well. Please give me write access to your PR. |
Update: Nvm, put Not sure how to resolve this in
From commit:
|
91 perf score! Haven't seen that in quite a while... Awesome! |
Not a big deal but I'd rather create our own "YoutubeEmbed" component (using this lib) in "website/src/theme/components" rather than importing a third-party lib everywhere directly |
Pre-flight checklist
Motivation
As discussed with @Josh-Cena. This is recommended in the lighthouse docs:
https://web.dev/third-party-facades/?utm_source=lighthouse&utm_medium=devtools#youtube-embedded-player
Test Plan
Test links
Deploy preview:
Related issues/PRs
#6746