Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Massoud Maboudi's portfolio to showcase #7406

Closed
wants to merge 2 commits into from
Closed

docs: add Massoud Maboudi's portfolio to showcase #7406

wants to merge 2 commits into from

Conversation

massoudmaboudi
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Another RTL website from @massoudmaboudi 😁

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 12, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very, very awesome website! However it leaves me very ambivalent, because while it's highly designed, it doesn't showcase much docs feature of Docusaurus😟 I'm open to add it to the favorites, but I'm afraid it doesn't represent a typical use-case... Do you have plans to add more docs-related pages to this site in the future?

@massoudmaboudi
Copy link
Contributor Author

This is a very, very awesome website! However it leaves me very ambivalent, because while it's highly designed, it doesn't showcase much docs feature of Docusaurus😟 I'm open to add it to the favorites, but I'm afraid it doesn't represent a typical use-case... Do you have plans to add more docs-related pages to this site in the future?

Thanks, man,
Yes, the blog is on the way. not this week but very soon.

@Josh-Cena
Copy link
Collaborator

Good to know! 👍 Looking forward to it, then

@massoudmaboudi
Copy link
Contributor Author

Good to know! 👍 Looking forward to it, then

Sure things.
I am not sure about docs section though as its a portfolio website but a different design of blog can help to make it glow.

@netlify
Copy link

netlify bot commented May 12, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 1155b28
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627d23699590210008d43741
😎 Deploy Preview https://deploy-preview-7406--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 12, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 68 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 85 🟢 99 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena
Copy link
Collaborator

Ye I'll be equally happy if it ends up a personal blog! We've never had a personal blog in the favorites, so it's always meaningful to add one

@massoudmaboudi
Copy link
Contributor Author

massoudmaboudi commented May 12, 2022

Ye I'll be equally happy if it ends up a personal blog! We've never had a personal blog in the favorites, so it's always meaningful to add one

Yes, working on https://iammassoud.ir and my other website which is https://datagit.ir already added to the favorite before.

btw, check a preview of my new design for https://datagit.ir as below:
https://pythonbeginnercourse--datagit-preview.netlify.app/

check categories and internal pages also

The blog section also is active in my new design

@netlify
Copy link

netlify bot commented May 12, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit e9f3191
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/627d23ba6bd4080008e19cba
😎 Deploy Preview https://deploy-preview-7406--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@massoudmaboudi
Copy link
Contributor Author

Hi @Josh-Cena
I didn't understand why the PR is closed

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented May 13, 2022

@massoudmaboudi Did you accidentally delete your branch? I have no idea what's going on...

@Josh-Cena Josh-Cena reopened this May 13, 2022
@massoudmaboudi
Copy link
Contributor Author

my fork was on the time the main branch name was master.
Seems my fork is updated. not sure, but reapply for this change shortly. Hope my other PR is active still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants