nl2br ignores \r in 3.3.0

[Majkl578]

echo nl2br("Hello<br />\nmy<br />\r\nfriend<br />\n\r", TRUE);

On PHP, the output is correct:

Hello<br /><br />
my<br /><br />
friend<br /><br />

On HHVM, output is broken and even tags are broken:

Hello<br /><br />
<br />/>
friend<br /><br />

And even worse if 2nd parameter is FALSE (no XHTML) - still generates XHTML, but broken even more:

Hello<br /><br>
<br>r />
friend<br /><br>

On 3.2.0 and earlier, output was wrong as well, but never broken:

Hello<br /><br />
my<br />
<br />
friend<br /><br />

[SiebelsTim]

It fails for me even in 3.2.0.
I think this is due to HHVM not handling the \r at all.
See https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext/ext_string.cpp#L279-L291 and https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext/std/ext_std_string.cpp#L24

[ptarjan]

Yeah, we screw up on \r. Compare http://3v4l.org/olqqs http://3v4l.org/6pgnv

[Majkl578]

Yeah, that would not be a big deal. But the major problem is that it leads to a data loss; look at the output in 3.3.0, "my" is completely missing and one tag is partially lost as well. I guess that, under some circumstances, it might be even considered as a security problem.

[MaideCa]

I believe your data loss is actually just the carriage return moving the printing cursor to the start of the line and then you write over your other characters.

[Majkl578]

@MaideCa: Right, that would be the case. :) It got split from \n and became interpreted in output in a confusing way...