[compiler][be] Promote destructured params to temporaries

Addresses a follow-up from the previous PR. Destructured function params are currently not eagerly promoted to temporaries: we wait until PromotedUsedTemporaries. But params _always_ have to be named, so we can promote when constructing HIR.

ghstack-source-id: ec0c6bec7349c207770fb93dabb9253650f6f0fc
Pull Request resolved: #30332

compiler/packages/babel-plugin-react-compiler/src/HIR/BuildHIR.ts

@@ -129,6 +129,7 @@ export function lower(
         reactive: false,
         loc: param.node.loc ?? GeneratedSource,
       };
+      promoteTemporary(place.identifier);
       params.push(place);
       lowerAssignment(
         builder,

compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts

@@ -41,7 +41,6 @@ import {
   ValidIdentifierName,
   getHookKind,
   makeIdentifierName,
-  promoteTemporary,
 } from "../HIR/HIR";
 import { printIdentifier, printPlace } from "../HIR/PrintHIR";
 import { eachPatternOperand } from "../HIR/visitors";
@@ -278,16 +277,6 @@ export function codegenFunction(
     pruneUnusedLValues(reactiveFunction);
     pruneHoistedContexts(reactiveFunction);
 
-    /*
-     * TODO: temporary function params (due to destructuring) should always be
-     * promoted so that they can be renamed
-     */
-    for (const param of reactiveFunction.params) {
-      const place = param.kind === "Identifier" ? param : param.place;
-      if (place.identifier.name === null) {
-        promoteTemporary(place.identifier);
-      }
-    }
     const identifiers = renameVariables(reactiveFunction);
     logReactiveFunction("Outline", reactiveFunction);
     const codegen = codegenReactiveFunction(