Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a random bug in react-dom development #13974

Closed
wants to merge 1 commit into from
Closed

Fixed a random bug in react-dom development #13974

wants to merge 1 commit into from

Conversation

provokateurin
Copy link

I found a random bug in react-dom, but only in development:

ERROR in ./node_modules/react-dom/cjs/react-dom.development.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
SyntaxError: node_modules/react-dom/cjs/react-dom.development.js: Unexpected token, expected ";" (13463:228)

A string was not escaped correctly, but only in development it throws this error.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@sizebot
Copy link

sizebot commented Oct 25, 2018

Details of bundled changes.

Comparing: 275e76e...d692970

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@provokateurin
Copy link
Author

The checks failed, but it wasn't my changed code.
Look at the bottom of the output and then please rerun the checks.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@aweary
Copy link
Contributor

aweary commented Oct 26, 2018

It's using double quotes, so the single quotes don't need to be escaped. The syntax is valid, so the error you're getting has to be a result of some other issue. It seems like it was thrown by babel-loader which suggests you have an issue with your build setup.

Check our community support resources for help on that:
https://facebook.github.io/react/community/support.html

@aweary aweary closed this Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants