Inject overrideProps() fn to DevTools #14427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function will enable editing props for function components, host nodes, and special types like memo and forwardRef.
sebmarkbage
reviewed
Dec 12, 2018
| if (fiber.alternate) { | ||
| fiber.alternate.pendingProps = fiber.pendingProps; | ||
| } | ||
| flushPassiveEffects(); |
There was a problem hiding this comment.
Why is this after setting the pendingProps? What if these effects synchronously renderers an update to this tree?
There was a problem hiding this comment.
Somewhat arbitrary (so I'll move it).
Seems a little weird either way, since such a synchronous re-renderer would mean we're reading from stale memoizedProps when we do our copy.
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: a22880e...3c84766 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
sebmarkbage
approved these changes
Dec 13, 2018
bvaughn
deleted the
support-DevTools-prop-updates-for-non-class-components
branch
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Inject overrideProps() fn to DevTools This function will enable editing props for function components, host nodes, and special types like memo and forwardRef.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
* Inject overrideProps() fn to DevTools This function will enable editing props for function components, host nodes, and special types like memo and forwardRef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function will enable editing props for function components, host nodes, and special types like
memoandforwardRef.Copying the update logic into React will also enable us to add more complex behavior in the future– such as the ability to override props in a way that won't get overridden unless the component is re-rendered with a new props value.
Demo
Here's a demo that shows me editing a
Context.Providervalue,React.memoandReact.forwardRefprops, host node props, and function component props.Unblocks facebook/react-devtools/pull/1249