Disable legacy context #27830
Closed
Disable legacy context #27830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
kassens
force-pushed
the
enable-disableLegacyContext
branch
2 times, most recently
from
ac37c2c to
4233a4c
Compare
kassens
commented
Dec 12, 2023
| !require('shared/ReactFeatureFlags').disableModulePatternComponents && | ||
| !require('shared/ReactFeatureFlags').disableLegacyContext | ||
| ) { | ||
| it('renders an error state if module-style context provider throws in componentWillMount', () => { |
There was a problem hiding this comment.
I'm not exactly sure what's going on with these tests that @GATE doesn't work. I think it's that the test is expected to fail in prod, but doesn't because there's no deprecation warnings in prod.
There was a problem hiding this comment.
Needs to be:
// @gate !disableModulePatternComponents
// @gate !disableLegacyContext || !__DEV__
I fixed this in #28151
React is getting major Update? 👀 |
|
We can probably close this because I landed it to experimental already: #28151 |
kassens
force-pushed
the
enable-disableLegacyContext
branch
from
690d733 to
2a72516
Compare
|
Dupe of #27991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables legacy context for the next major release. These have been deprecated for a long time now and have been warning.