-
Notifications
You must be signed in to change notification settings - Fork 47.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): avoid escape non-English character #29124
Conversation
ad29355
to
b871f19
Compare
Comparing: 3f1436c...6464375 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I changed the behavior from modifying the babel config to changing StringLiteral to Template. Some feedback from @SukkaW that we cannot modify babel config in many cases |
So many breaking changes to tests. I don't think this is a good change |
Thanks for submitting this! The fix is a bit more involved, we should only apply the workaround if necessary (if babel would escape incorrectly). I'm also going to investigate if there is some way to just get the right escaping in older versions of babel. |
Summary
Fixes: #29120
Related: babel/babel#9804
How did you test this change?