-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pixelgl has been ported to GLFW 3.3. #211
Conversation
I have added a gamepad support. Actually, the old code didn't work correctly, because if you work with gamepad you have to use |
When is this going to get merged ? @faiface if you update pixel you get glfw errors |
Yeah, so what is going on here @faiface and @tracer8086 ? @tracer8086 seems to have a fork with using glfw 3.3, so should I move over to that? |
I'm also interested in glfw 3.3. Can we get some eyes on this PR @faiface ? |
I've done some basic testing of this fork against my lib and I didn't run into any issues. https://github.com/icholy/slippy |
@zergon321 would probably be better to split these changes into 2 PRs.
|
@icholy Yeah, that's right, but what I really needed personally is proper gamepad support which is impossible without moving to GLFW 3.3. But updating the repo to GLFW 3.3 is more global, so I named the PR after it. |
@zergon321 I understand, I just think these changes should be split up across two separate PRs so they can be considered in isolation. |
@icholy Ok, I've reverted two commits fixing the gamepad API. I hope this PR will get merged because the gamepad API just doesn't work correctly in its present state and, moreover, it's incomplete. |
@zergon321 I'm going to do #219 to get into the swing of things...Hope to do it today. Then I'll take a look at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the GLFW 3.3 update locally and based some work on it that requires features from 3.3.
Everything worked as expected 👍
Awesome, maybe I can get this out this weekend! If so I like your idea that this be tagged "x.x.x-alpha" |
OK lets go! |
Examples from the pixel-examples repository work good. Soon I will work on the gamepad support,