Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixelgl has been ported to GLFW 3.3. #211

Merged
merged 5 commits into from
May 9, 2020
Merged

pixelgl has been ported to GLFW 3.3. #211

merged 5 commits into from
May 9, 2020

Conversation

zergon321
Copy link
Contributor

Examples from the pixel-examples repository work good. Soon I will work on the gamepad support,

@zergon321
Copy link
Contributor Author

zergon321 commented Jan 5, 2020

I have added a gamepad support. Actually, the old code didn't work correctly, because if you work with gamepad you have to use GetGamepadState instead of GetButtons or GetAxes, otherwise the gamepad won't be properly mapped and its inputs will be interpreted incorrectly. For those who want to know more about mappings: GLFW Input Guide. Also you could check the full set of GLFW mappings.

This was referenced Jan 6, 2020
@steelx
Copy link

steelx commented Jan 6, 2020

When is this going to get merged ? @faiface if you update pixel you get glfw errors

@Chillance
Copy link

Chillance commented Mar 8, 2020

Yeah, so what is going on here @faiface and @tracer8086 ? @tracer8086 seems to have a fork with using glfw 3.3, so should I move over to that?

@jrcichra
Copy link

jrcichra commented Apr 1, 2020

I'm also interested in glfw 3.3. Can we get some eyes on this PR @faiface ?

@icholy
Copy link

icholy commented Apr 8, 2020

I've done some basic testing of this fork against my lib and I didn't run into any issues. https://github.com/icholy/slippy

@icholy
Copy link

icholy commented Apr 13, 2020

@zergon321 would probably be better to split these changes into 2 PRs.

  1. Update to GLFW 3.3
  2. Make breaking changes.

@zergon321
Copy link
Contributor Author

@icholy Yeah, that's right, but what I really needed personally is proper gamepad support which is impossible without moving to GLFW 3.3. But updating the repo to GLFW 3.3 is more global, so I named the PR after it.

@icholy
Copy link

icholy commented Apr 20, 2020

@zergon321 I understand, I just think these changes should be split up across two separate PRs so they can be considered in isolation.

@zergon321
Copy link
Contributor Author

zergon321 commented Apr 20, 2020

@icholy Ok, I've reverted two commits fixing the gamepad API. I hope this PR will get merged because the gamepad API just doesn't work correctly in its present state and, moreover, it's incomplete.

@delp
Copy link
Contributor

delp commented May 2, 2020

@zergon321 I'm going to do #219 to get into the swing of things...Hope to do it today. Then I'll take a look at this

Copy link
Contributor

@fgrosse fgrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the GLFW 3.3 update locally and based some work on it that requires features from 3.3.
Everything worked as expected 👍

@delp
Copy link
Contributor

delp commented May 9, 2020

Awesome, maybe I can get this out this weekend! If so I like your idea that this be tagged "x.x.x-alpha"

@delp
Copy link
Contributor

delp commented May 9, 2020

OK lets go!

@delp delp merged commit 197e604 into faiface:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants