New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cancelling the context with proper cancel function #26

Merged

farbodahm merged 1 commit into main from fix/context-cancellation

May 28, 2024

Owner

farbodahm commented May 28, 2024

Apparently my Copilot was calling ctx.Done() instead of cancel() function while auto completing the tests :))


          fix: cancelling the context

02aa3f9

farbodahm added the bug label

farbodahm self-assigned this

github-actions bot commented May 28, 2024

BenchmarkAddStaticColumnFunction Duration: 5.91s ⏳
BenchmarkFilterFunction Duration: 1.50s ⏳
BenchmarkRenameColumnFunction Duration: 2.40s ⏳
BenchmarkSchemaValidation Duration: 2.30s ⏳
BenchmarkSelect Duration: 2.40s ⏳

farbodahm merged commit 720a707 into main

3 checks passed

farbodahm deleted the fix/context-cancellation branch

May 28, 2024 19:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug