Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add logger module #27

Merged
merged 4 commits into from
May 31, 2024
Merged

feature: add logger module #27

merged 4 commits into from
May 31, 2024

Conversation

farbodahm
Copy link
Owner

@farbodahm farbodahm commented May 29, 2024

  • Add a basic logging module to be able to customize it based on the requirements (EX. log level, writer, ...)
  • Add dynamic configuration using Functional Option pattern

Closes #13.

Copy link

  • BenchmarkAddStaticColumnFunction Duration: 6.02s ⏳
  • BenchmarkFilterFunction Duration: 1.50s ⏳
  • BenchmarkRenameColumnFunction Duration: 2.40s ⏳
  • BenchmarkSchemaValidation Duration: 2.40s ⏳
  • BenchmarkSelect Duration: 2.40s ⏳

Copy link

  • BenchmarkAddStaticColumnFunction Duration: 6.11s ⏳
  • BenchmarkFilterFunction Duration: 1.50s ⏳
  • BenchmarkRenameColumnFunction Duration: 2.40s ⏳
  • BenchmarkSchemaValidation Duration: 2.30s ⏳
  • BenchmarkSelect Duration: 2.40s ⏳

@farbodahm farbodahm self-assigned this May 30, 2024
Copy link

  • BenchmarkAddStaticColumnFunction Duration: 5.92s ⏳
  • BenchmarkFilterFunction Duration: 1.50s ⏳
  • BenchmarkRenameColumnFunction Duration: 2.40s ⏳
  • BenchmarkSchemaValidation Duration: 2.40s ⏳
  • BenchmarkSelect Duration: 2.40s ⏳

Copy link

  • BenchmarkAddStaticColumnFunction Duration: 6.01s ⏳
  • BenchmarkFilterFunction Duration: 1.50s ⏳
  • BenchmarkRenameColumnFunction Duration: 2.40s ⏳
  • BenchmarkSchemaValidation Duration: 2.40s ⏳
  • BenchmarkSelect Duration: 2.40s ⏳

@farbodahm farbodahm force-pushed the refactor/add-logging-module branch from 907ba25 to 954f787 Compare May 31, 2024 09:26
Copy link

  • BenchmarkAddStaticColumnFunction Duration: 6.12s ⏳
  • BenchmarkFilterFunction Duration: 1.50s ⏳
  • BenchmarkRenameColumnFunction Duration: 2.40s ⏳
  • BenchmarkSchemaValidation Duration: 2.40s ⏳
  • BenchmarkSelect Duration: 2.40s ⏳

@farbodahm farbodahm marked this pull request as ready for review May 31, 2024 16:33
@farbodahm farbodahm added the enhancement New feature or request label May 31, 2024
@farbodahm farbodahm merged commit 2301cb1 into main May 31, 2024
3 checks passed
@farbodahm farbodahm deleted the refactor/add-logging-module branch May 31, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Config
1 participant