feat: Allow ENS resolver to answer more queries #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Accompanies farcasterxyz/fname-registry#505 to make nice ENS profiles from fnames. I also added additional checks on the CCIP Read callback function for extra safety.
I wasn't sure what the version should be, so left that untouched for now.
Change Summary
Adds support for
addr(node, cointype)
andtext(node, key)
lookups by changing the EIP-712 type.Merge Checklist
PR-Codex overview
This PR focuses on enhancing the
FnameResolver
contract and its related tests by introducing new parameters, modifying function signatures, and improving error handling for resolver functions.Detailed summary
pre-commit
hook in.rusty-hook.toml
.FNAME_RESOLVER_DNS_ENCODED_NAME
andFNAME_RESOLVER_PASSTHROUGH_ADDRESS
environment variables.DeploymentParams
struct andrunDeploy
function inscript/DeployL1.s.sol
.FnameResolver
contract with new mappings for allowed functions and text records.resolve
andresolveWithProof
functions to improve validation and error handling.MockResolver
contract for testing purposes.FnameResolverTest
to cover new functionality and edge cases.