Faster tracing test #6
Conversation
Python/ceval.c
Outdated
| #define TARGET(op) \ | ||
| op: \ | ||
| TARGET_##op |
There was a problem hiding this comment.
Maybe make this macro a one-liner too? It would seem to fit. :-)
Python/ceval.c
Outdated
| #else | ||
| #define TARGET(op) op | ||
| #define DISPATCH_GOTO goto dispatch_opcode; |
There was a problem hiding this comment.
For stylistic reasons (consistency with e.g. DISPATCH()) I'd prefer making this a function macro, and moving the semicolon to after the "call". Seeing DISPATCH_GOTO (line 1317) without a semicolon makes my mind do a double-take each time I see it.
| CFrame *prev_cframe = tstate->cframe; | ||
| trace_info.cframe.use_tracing = prev_cframe->use_tracing; | ||
| trace_info.cframe.previous = prev_cframe; | ||
| tstate->cframe = &trace_info.cframe; |
There was a problem hiding this comment.
Hm, this is disturbing -- tstate (which is pretty much a global structure) now has a pointer to a local variable. That means you have to restore this on every exit from the function. Now, we know there's only one exit, and it's handled there, but it still makes me feel weird. And all this to make it possible to set a single int (perhaps even a single bit) from "outside" this function.
There was a problem hiding this comment.
I know, and it would seem like overkill, if it weren't for how critical reads of that single int are.
That one int gets read 100 million times per second, and the code to read it occurs over 100 times in the interpreter.
|
I've made the relevant changes to python#25244 |
markshannon
force-pushed
the
faster-tracing-test
branch
3 times, most recently
from
f9fdb65 to
7262620
Compare
markshannon
force-pushed
the
faster-tracing-test
branch
from
7262620 to
2cf3c98
Compare
For review only