[action] carthage - add use_xcframeworks option

[att55]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Description

Carthage has --use-xcframeworks option since ver.0.37.0.
So, I also added the option to CarthageAction.

https://github.com/Carthage/Carthage/releases/tag/0.37.0

[ainame]

This is same as #18077
Can you please add type and shrink test cases?

[ainame]

Suggested change

	context "when command is update" do
	let(:command) { 'update' }
	it "adds the use_xcframeworks option" do
	result = Fastlane::FastFile.new.parse("lane :test do
	carthage(command: '#{command}', use_xcframeworks: true)
	end").runner.execute(:test)
	expect(result).to eq("carthage update --use-xcframeworks")
	end
	end
	context "when command is build" do
	let(:command) { 'build' }
	it "adds the use_xcframeworks option" do
	result = Fastlane::FastFile.new.parse("lane :test do
	carthage(command: '#{command}', use_xcframeworks: true)
	end").runner.execute(:test)
	expect(result).to eq("carthage build --use-xcframeworks")
	end
	end
	context "when command is bootstrap" do
	let(:command) { 'bootstrap' }
	it "adds the use_xcframeworks option" do
	result = Fastlane::FastFile.new.parse("lane :test do
	carthage(command: '#{command}', use_xcframeworks: true)
	end").runner.execute(:test)
	expect(result).to eq("carthage bootstrap --use-xcframeworks")
	end
	end
	context "when valid command is used for --use-xcframeworks option" do
	it "adds the use_xcframeworks option" do
	['update', 'build', 'bootstrap'].each do |command|
	result = Fastlane::FastFile.new.parse("lane :test do
	carthage(command: '#{command}', use_xcframeworks: true)
	end").runner.execute(:test)
	expect(result).to eq("carthage bootstrap --use-xcframeworks")
	end
	end
	end

I think you can combine those cases into one case. Can you please do that?

[att55]

@ainame
Thanks for your review and suggestion!
But, I think the expectation should be like below.

expect(result).to eq("carthage #{command} --use-xcframeworks")

Except for that, I will take your suggestion in PR 👍

[att55]

@ainame Added type and combined test cases in one case 👍
Please check when you're available.

[ainame]

LGTM👍 @joshdholtz will double-check and merge this when he can 🙇

[att55]

@ainame It seems like one job is failed.
https://app.circleci.com/pipelines/github/fastlane/fastlane/2080/workflows/612d07b0-3f6b-4ee9-9d6d-9a6e00e59c7b/jobs/61174

[ainame]

It's a known flaky test case. Don't worry.

[joshdholtz]

Thanks again for another carthage addition! Really appreciate it ❤️

[fastlane-bot]

Hey @att55 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.174.0 🚀