[match] nuke now supports filtering by specific certificates #19584
Conversation
match/lib/match/nuke.rb
Outdated
| # Force will continue to revoke and delete all certificates and profiles | ||
| return if self.params[:force] | ||
| return if self.certs.count < 2 |
There was a problem hiding this comment.
i think, we should early return if this func will be running on CI, because users cant input/select specific certificates on CI? 🤔
There was a problem hiding this comment.
Good point 👍.
Would return unless UI.interactive? do the job?
If it does, other possibility would be check if we're in interactive mode in run
prepare_list
filter_by_cert if UI.interactive?
print_tables
match/lib/match/nuke.rb
Outdated
| # Force will continue to revoke and delete all certificates and profiles | ||
| return if self.params[:force] | ||
| return if self.certs.count < 2 |
There was a problem hiding this comment.
Good point 👍.
Would return unless UI.interactive? do the job?
If it does, other possibility would be check if we're in interactive mode in run
prepare_list
filter_by_cert if UI.interactive?
print_tables
match/lib/match/nuke.rb
Outdated
| })) | ||
| puts("") | ||
|
|
||
| if UI.confirm("Do you want to nuke specific certificates and their associated profiles?") |
There was a problem hiding this comment.
Does it make sense to add an explanation that Declining will nuke all the listed certificates and their associated profiles
There was a problem hiding this comment.
I like this idea!
Also, @lucgrabowski... Do you mind sending me an email over at me AT joshholtz DOT com? 😇 Tried looking for contact info for you on your GitHub profile but couldn't find any 🤷♂️
There was a problem hiding this comment.
Hi @joshdholtz, sure, I'll send you an email.
joshdholtz
force-pushed
the
joshdholtz-nuke-by-certificate
branch
from
6b1e68a to
64859fe
Compare
|
Hey @joshdholtz 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
|
Congratulations! 🎉 This was released as part of fastlane 2.198.0 🚀 |
Motivation and Context
Match's nuke has always nuke all certificate and provisioning profiles without giving an option to nuke only a subset with filtering. This behavior worked out great unless you had a lot of certificates and profiles that were good and there were only a few that were bad or expired that you wanted to revoke and delete.
This new behavior allows optional filtering by one to many certificates which will filter the only to those specified certificates and the profiles that use them.
Description
filter_by_certmethod afterprepare_listand beforeprint_tablesthat offers user the option to filter by certificate:forceis set totrue[15:22:36]: Fetching certificates and profiles... +--------+----------------------+------------+-------------+------------+ | Certificates that can be revoked | +--------+----------------------+------------+-------------+------------+ | Option | Name | ID | Type | Expires | +--------+----------------------+------------+-------------+------------+ | 1 | Apple Distribution: | 297G643675 | Certificate | 2022-08-25 | | | Josh Holtz | | | | | 2 | Apple Distribution: | YS3CC9B4F9 | Certificate | 2022-08-25 | | | Josh Holtz | | | | +--------+----------------------+------------+-------------+------------+ [15:22:38]: Do you want to nuke specific certificates and their associated profiles? (y/n) y [15:22:43]: Enter the "Option" number(s) from the table above? (comma-separated) 1 +---------------------------+------------+-------------+------------+ | Certificates that are going to be revoked | +---------------------------+------------+-------------+------------+ | Name | ID | Type | Expires | +---------------------------+------------+-------------+------------+ | Apple Distribution: Josh | 297G643675 | Certificate | 2022-08-25 | | Holtz | | | | +---------------------------+------------+-------------+------------+ +-------------------------+------------+--------+---------------+------------+ | Provisioning Profiles that are going to be revoked | +-------------------------+------------+--------+---------------+------------+ | Name | ID | Status | Type | Expires | +-------------------------+------------+--------+---------------+------------+ | match AppStore | 5299GP27D9 | ACTIVE | IOS_APP_STORE | 2022-08-25 | | com.joshholtz.CrunchyG | | | | | | IF | | | | |Testing Steps
Update
Gemfileand runbundle install,bundle update fastlane, orbundle update