Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [update_code_signing_settings] add entitlements file path ca… #19678

Merged

Conversation

abcdev
Copy link
Contributor

@abcdev abcdev commented Dec 7, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Fastlane already has a couple of actions to change/add entries in an apps entitlements file but there is no action that considers that this file is not added to the build settings. Leaving no other option than manually adding this file by opening the project in Xcode and clicking through UI.

We'd like to integrate fastlane into CI/CD of one of our projects where these entitlements files are generated on a per client basis. Hence the need for automation at this point.

Description

Extended the existing action update_code_signing_settings to also handle the build setting CODE_SIGN_ENTITLEMENTS.

Testing Steps

Added test case to existing update_code_signing_settings_spec.rb to add the new CODE_SIGN_ENTITLEMENTS entry in a Xcode project file where it is missing and to modify a project with an already existing one.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I've had to do this for a project and I did it a manually way so I'm wishing I had this then 😛 Thanks so much for the contribution 😍

@joshdholtz joshdholtz merged commit 60583e0 into fastlane:master Dec 9, 2021
@fastlane-bot
Copy link

Hey @abcdev 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.199.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants