[action] [update_code_signing_settings] add entitlements file path ca… #19678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Fastlane already has a couple of actions to change/add entries in an apps entitlements file but there is no action that considers that this file is not added to the build settings. Leaving no other option than manually adding this file by opening the project in Xcode and clicking through UI.
We'd like to integrate fastlane into CI/CD of one of our projects where these entitlements files are generated on a per client basis. Hence the need for automation at this point.
Description
Extended the existing action
update_code_signing_settings
to also handle the build settingCODE_SIGN_ENTITLEMENTS
.Testing Steps
Added test case to existing
update_code_signing_settings_spec.rb
to add the newCODE_SIGN_ENTITLEMENTS
entry in a Xcode project file where it is missing and to modify a project with an already existing one.