Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supply] add an option to change the release status of a promoted track #19701

Merged

Conversation

joeflateau
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #19511

Description

Adds an option to set the release status of a promoted track

Testing Steps

Upload an apk/aab to an internal track with status complete and promote the track to production in draft status.

@joshdholtz
Copy link
Member

@joeflateau Hey, stranger! 👋 Curious if this is still WIP and if you need anything from me? No rush but just doing a curtsey check 😊

@joeflateau
Copy link
Contributor Author

@joshdholtz howdy 🤠 two users from #19511 were going to be testing in the new year. I've been holding this in draft state until they got a chance to. I can move it along if it's cluttering up the queue

@joshdholtz
Copy link
Member

@joshdholtz howdy 🤠 two users from #19511 were going to be testing in the new year. I've been holding this in draft state until they got a chance to. I can move it along if it's cluttering up the queue

@joeflateau Nah nah nah, not cluttering up the queue at all! Just wanted to make sure I wasn't holding anything up here 😊 Just ping me its ready for me to review!

@joeflateau joeflateau marked this pull request as ready for review January 11, 2022 15:14
@joeflateau
Copy link
Contributor Author

@joshdholtz this has now been tested and confirmed to work properly 🙂 ready for review

@Xazen
Copy link

Xazen commented Jan 11, 2022

@joeflateau finally got around to testing it. With this parameter, I can promote a build to the production lane in a draft state. 🎉

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🔥 Really love this addition! Thanks so much for the contribution 🥰

@joshdholtz joshdholtz merged commit e04b8c3 into fastlane:master Jan 13, 2022
@joeflateau joeflateau deleted the pr/supply-promote-release-status-1 branch January 13, 2022 14:32
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.200.0 🚀

@quentin23soleil
Copy link

quentin23soleil commented Jan 17, 2022

👋 just wondering why draft->inProgress is not possible with this?

Oh wait, it is, but requires the version_code? 😭

@fastlane fastlane locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changes_not_sent_for_review = true unexpectedly sends to review automatically after promoting to production
5 participants