[action][danger] add GitHub Enterprise flags #20216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for GitHub enterprise flags and fail-if-no-pr flag
|
@joshdholtz I am not sure if it is ok to directly ping you, but maybe you know someone who could help here :) I saw that one CI test is failing due to ==> Tapping homebrew/bundle
Cloning into '/usr/local/Homebrew/Library/Taps/homebrew/homebrew-bundle'...
Warning: Permanently added the ECDSA host key for IP address '140.82.112.3' to the list of known hosts.\r
Tapped 1 command (99 files, 1.9MB).
Installing swiftformat
==> Downloading https://ghcr.io/v2/homebrew/core/swiftformat/manifests/0.49.7
curl: (22) The requested URL returned error: 503
Error: swiftformat: Failed to download resource "swiftformat_bottle_manifest"
Download failed: https://ghcr.io/v2/homebrew/core/swiftformat/manifests/0.49.7But I couldn't figure out how my changes could cause this. Do you know what could be the root cause here ? |
|
Looks random CI failure, Retrigger failing job: |
Thanks for the retrigger - green now 👍 |
joshdholtz
changed the title
joshdholtz
approved these changes
May 18, 2022
|
Congratulations! 🎉 This was released as part of fastlane 2.206.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
This PR adds missing configurations for using the
dangeraction with GitHub Enterprise. This is a nice addition and makes it possible to omit the manual setting of Danger related environment variables before executing fastlane.Description
This PR adds the corresponding ConfigItems and set the corresponding environment variables based on https://danger.systems/guides/getting_started.html#enterprise-github
Additionally I saw that there were no tests present for the
fail-if-no-prflag, so I also added them.Testing Steps