Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastlane][tests] add tests for CLIToolsDistributor #20315

Merged
merged 4 commits into from
May 25, 2022
Merged

[fastlane][tests] add tests for CLIToolsDistributor #20315

merged 4 commits into from
May 25, 2022

Conversation

lucgrabowski
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

Adding more tests for CLIToolsDistributor to check tool aliases mapping.
Adding TOOL_ALIASES hash.

Testing Steps

@joshdholtz joshdholtz changed the title Add tests for CLIToolsDistributor [fastlane][tests] add tests for CLIToolsDistributor May 25, 2022
joshdholtz
joshdholtz approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this cleanup 😊 Thank you thank you!

@joshdholtz joshdholtz merged commit 1238c39 into master May 25, 2022
@joshdholtz joshdholtz mentioned this pull request May 25, 2022
Merged
@lucgrabowski lucgrabowski deleted the lucgrabowski-add-tests-for-cli branch May 25, 2022 09:24
fastlane-bot
fastlane-bot reviewed May 25, 2022
View reviewed changes
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.206.2 🚀

@vinayseasia vinayseasia mentioned this pull request Jun 8, 2022
Closed
@fastlane fastlane locked and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fastlane-bot fastlane-bot fastlane-bot left review comments

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucgrabowski @joshdholtz @fastlane-bot