Explicit beta group access to all builds at creation

[vincentisambart]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

When creating a beta group, the App Store Connect API let you specify if this new group has access to all existing builds or not, but fastlane did not let you specify it, setting it to true for internal groups, and false for external ones.

I wanted to be able to create internal groups that do not have access to existing builds.

Description

This change lets you explicitly specify if the new group has access to all existing builds or not. If you do not specify this new parameter, the behavior is the same as before.

Testing Steps

[rogerluan]

Hi @vincentisambart 👋 could you merge master into your branch (or rebase it)? There was a fix to our CI that is in master that should make your PR pass all checks 🙏

Thank you!

[vincentisambart]

Rebase done 😁

[getaaron]

The code change looks good, and thanks for rebasing. We should just add test coverage for this condition and then we'll be good to merge 👍

[vincentisambart]

I checked but creating a few beta groups on App Store Connect, and if isInternalGroup is false, the value of hasAccessToAllBuilds is ignored and in the response hasAccessToAllBuilds is set to nil. Of course I did also check that passing nil was fine on the real server.

[getaaron]

For a future PR, it might be nice to catch this and print a warning instead of silently ignoring the invalid parameter

[vincentisambart]

I'll make a new 1-line PR

[vincentisambart]

@getaaron I improved a bit the code, added has_access_to_all_builds to the BetaGroup model, and added tests 😁

[getaaron]

@vincentisambart looks like there's still some CI failure

@rogerluan have you seen this one?

[rogerluan]

Looks like a flaky test... 🤔

[vincentisambart]

I updated the commit date without changing the content to rerun the test.

[vincentisambart]

It seems after retry all tests passed.

[rogerluan]

I updated the commit date without changing the content to rerun the test.

haha I had already retriggered CI from the re-run button, but I appreciate it 😊 glad the tests passed! I've never seen that flaky test before, but I'll keep an eye on it 👀

[getaaron]

Thanks very much for the PR and all the follow up!

[vincentisambart]

Thank you for the review!