Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pre-parsing of ESI document, add example of fetching per-user fragment variants #30

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Allow pre-parsing of ESI document, add example of fetching per-user fragment variants #30

merged 5 commits into from
Dec 11, 2024

Conversation

kailan
Copy link
Member

@kailan kailan commented Oct 11, 2024 •
edited
Loading

Resolves #3

@kailan kailan marked this pull request as ready for review October 23, 2024 13:42
@kailan kailan added the enhancement New feature or request label Oct 23, 2024
@kailan kailan requested a review from vagetman October 23, 2024 15:35
vagetman
vagetman reviewed Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@vagetman vagetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor details

@kailan
Copy link
Member Author

kailan commented Dec 6, 2024

Thanks for the review @vagetman, I addressed all of those comments. How's it looking now?

@kailan kailan requested a review from vagetman December 6, 2024 14:52
@kailan kailan merged commit ee34e76 into main Dec 11, 2024
1 check passed
@kailan kailan deleted the variants branch December 11, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagetman vagetman vagetman approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to pre-parse document for fragment URLs
2 participants
@kailan @vagetman