Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking to distro package #1064

Closed
glensc opened this issue Mar 17, 2021 · 5 comments
Closed

Linking to distro package #1064

glensc opened this issue Mar 17, 2021 · 5 comments
Labels
Low Priority This ticket has a low priority type.feature New feature

Comments

@glensc
Copy link
Contributor

glensc commented Mar 17, 2021

I see that adcli has a link to Fedora distribution:

image

how to add such link to other distributions?

@Zlopez
Copy link
Contributor

Zlopez commented Mar 17, 2021

This was added by this PR created by @abitrolly, feel free to look how you can do it for other distribution.

@glensc
Copy link
Contributor Author

glensc commented Mar 17, 2021

Oh, such wow hack, no problem adding another one:

But I think the distro mapping should come from config rather hardcoded conditions to template.
Also, that template is huge, I'm sure the templating engine used supports "include" other templates to make templates smaller and more specific function.

I'll leave those concerns to maintainers.

@Zlopez
Copy link
Contributor

Zlopez commented Mar 17, 2021

We could make it configurable, but it's not really a priority right now.

That template is that huge till the time I started maintaining that project, there wasn't really that much changed, but splitting it to multiple sub-templates sounds like a good way to make it better maintainable.

@Zlopez
Copy link
Contributor

Zlopez commented Mar 17, 2021

I added #1067 and #1066 to track these enhancements.

@Zlopez Zlopez linked a pull request Mar 17, 2021 that will close this issue
@Zlopez Zlopez added type.feature New feature Low Priority This ticket has a low priority labels Mar 17, 2021
@Zlopez
Copy link
Contributor

Zlopez commented Mar 19, 2021

I will close this one in favor of #1066

@Zlopez Zlopez closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority This ticket has a low priority type.feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants