-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PLD Linux package link to project page #1065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a news file. See https://anitya.readthedocs.io/en/latest/contributing.html#release-notes or look at the #1053
Added. However, I think the change is rather trivial not worth the changelog entry:
Also, I think the effort for changelog creation, is too much for developers. Especially, if want to make a simple change from GitHub Web. Traversing files, finding where to add them, and whats the syntax. Bleh. You should look into better release workflows that can obtain the changelog/release notes from pull request titles and labels. I personally have been keeping an eye on https://github.com/laminas/automatic-releases My 2¢ (not attached) |
Codecov Report
@@ Coverage Diff @@
## master #1065 +/- ##
=======================================
Coverage 97.38% 97.38%
=======================================
Files 65 65
Lines 4285 4285
Branches 598 598
=======================================
Hits 4173 4173
Misses 65 65
Partials 47 47 Continue to review full report at Codecov.
|
I only want the news file for changes that would be interesting for users of the application. If this is just some small change in documentation or fix for some typo in code I wouldn't care about it. |
news/1065.feature
Outdated
@@ -0,0 +1 @@ | |||
Add PLD Linux package link to project page. #1065, #1064 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the link from the news file, those aren't needed.
Add PLD Linux package link to project page. #1065, #1064 | |
Add PLD Linux package link to project page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How else would you have a link to both of them in changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wouldn't work because the link will point to issue with id 1065, which doesn't exists.
yes, it will work tecnically, GitHub has a unique id namespace for issues and pull requests, and they both redirect to each other:
https://github.com/fedora-infra/anitya/issues/1065
https://github.com/fedora-infra/anitya/pull/1064
I would rather rename it to PR1065.feature
then, as while it #1065 covers #1064, it doesn't solve it, i.e it's a rather open question for documentation or something.
however, I can't do file rename from GitHub web, so need to check out this locally to make changes, so this will take time.
(edited example links, as GitHub rendered the links as #NUMBER
, making the point not understandable)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this
I was able to test it on the local instance of Anitya and the link is working fine, it redirected me to the source repo of the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change name of the news file to point to correct issue.
Thanks, @Zlopez this will help to verify matched package validity more easily! |
No problem, I will merge the current pull requests and release a new version, so it will be in release-monitoring.org soon. |
Similarly to #1053