Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread timeout in check_service #1284

Closed
Zlopez opened this issue Jan 31, 2022 · 0 comments · Fixed by #1285
Closed

Thread timeout in check_service #1284

Zlopez opened this issue Jan 31, 2022 · 0 comments · Fixed by #1285
Assignees
Labels

Comments

@Zlopez
Copy link
Contributor

Zlopez commented Jan 31, 2022

#1274 introduced a new bug to Anitya. The threads are timing out in check_service.py.

This is probably caused by not doing session.commit() when there are no new versions and the session is just hanging there. This isn't issue during the test, but it's issue in check_service.py.

This should be easily fixed by changing the conditions in anitya.lib.utilities.py.

@Zlopez Zlopez self-assigned this Jan 31, 2022
@Zlopez Zlopez changed the title Thread timeout Thread timeout in check_service Jan 31, 2022
Zlopez added a commit that referenced this issue Jan 31, 2022
Session.commit() needs to be called every time there isn't any test run
not only if there are new versions found.

Fixes #1284

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit that referenced this issue Jan 31, 2022
Session.commit() needs to be called every time there isn't any test run
not only if there are new versions found.

Fixes #1284

Signed-off-by: Michal Konečný <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant