Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards incompatible API change? #1395

Closed
Jille opened this issue Jun 28, 2022 · 3 comments
Closed

Backwards incompatible API change? #1395

Jille opened this issue Jun 28, 2022 · 3 comments

Comments

@Jille
Copy link

Jille commented Jun 28, 2022

Hi.

We (https://www.snoozethis.com) recently integrated with your API to allow our users to wait for new releases on e.g. GitHub.

This broke around June 22nd. Previously we POSTed {"id":"1234"} to https://release-monitoring.org/api/v2/versions/ but that started returning HTTP 400s. We switched to GETting https://release-monitoring.org/api/v2/versions/?project_id=1234 and that seems to work now.

The commit message in #1105 indicates it wasn't supposed to change.

@Zlopez
Copy link
Contributor

Zlopez commented Jun 29, 2022

This wasn't an intended change. We just replaced the old API backend which wasn't supported anymore to new one.
One thing that came to my mind at first glance, maybe the old API backend was not that strict regarding data types. The id was defined as int and looking at our POST request your are sending string. So changing the payload to {"id":1234} should fix the issue. It would also explain HTTP 400. The GET will work as well.

@Zlopez
Copy link
Contributor

Zlopez commented Aug 2, 2022

@Jille Did you tried to change the id in post request to int?

@Zlopez
Copy link
Contributor

Zlopez commented Sep 14, 2022

I'm closing this issue, because it's not an issue with API. If there is still something to discuss here feel free to open the ticket.

@Zlopez Zlopez closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants