Replace flask-restful #1105
Merged
Replace flask-restful #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Flask restful had last release in 2014 and the CI started failing because of some dependencies that are no longer available. I decided to replace flask-restful with [flask.view.MethodView](https://flask.palletsprojects.com/en/2.0.x/views/#method-based-dispatching) and [webargs](https://webargs.readthedocs.io/en/latest/index.html). The API will not change, but the error messages will be slightly different. Signed-off-by: Michal Konečný <[email protected]>
Zlopez
force-pushed
the
replace_flask_restful
branch
from
1cc875c to
5ed3705
Compare
|
This pull request introduces 1 alert when merging 5ed3705 into 332bfb5 - view on LGTM.com new alerts:
|
The overriden error_handler doesn't have correct signature, let's fix this. Signed-off-by: Michal Konečný <[email protected]>
Signed-off-by: Michal Konečný <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1105 +/- ##
==========================================
- Coverage 97.37% 97.34% -0.03%
==========================================
Files 64 64
Lines 4268 4220 -48
Branches 598 600 +2
==========================================
- Hits 4156 4108 -48
Misses 65 65
Partials 47 47
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flask restful had last release in 2014 and the CI started failing
because of some dependencies that are no longer available.
I decided to replace flask-restful with
flask.view.MethodView and
webargs. The API will not change, but the error messages will be
slightly different.
Signed-off-by: Michal Konečný [email protected]