Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Please add a "preview" mode #491

Closed
genodeftest opened this issue Jun 1, 2017 · 2 comments · Fixed by #983
Closed

[RFE] Please add a "preview" mode #491

genodeftest opened this issue Jun 1, 2017 · 2 comments · Fixed by #983
Labels
groomed Medium Priority This ticket has a medium priority type.feature New feature
Milestone

Comments

@genodeftest
Copy link

It would be nice to have a preview mode, which does the version checks, but does not send notifications.

@jeremycline jeremycline added the type.feature New feature label Jun 1, 2017
@Zlopez Zlopez added the Medium Priority This ticket has a medium priority label Mar 5, 2019
@Zlopez
Copy link
Contributor

Zlopez commented Mar 5, 2019

This needs a new logic for project checking working with data that aren't saved in the database yet.

@Zlopez
Copy link
Contributor

Zlopez commented Apr 30, 2019

Implementations details

To make this work we need to implement few things:

  1. Add a new button on https://github.com/release-monitoring/anitya/blob/master/anitya/templates/project_new.html that will do the test check
  2. Re-implement check_project_release (https://github.com/release-monitoring/anitya/blob/master/anitya/lib/utilities.py#L76) so we could call it with specific arguments and without access to database
  3. Add a new UI method to https://github.com/release-monitoring/anitya/blob/master/anitya/ui.py that will read the form fields and call the above method

@Zlopez Zlopez added this to the 1.0 milestone Mar 16, 2020
@Zlopez Zlopez added the groomed label May 25, 2020
Zlopez added a commit to Zlopez/anitya that referenced this issue Nov 4, 2020
This adds API v2 versions target with GET and POST methods.
* GET method allows user to get versions that are currently available on the project.
* POST allows user to apply temporary changes and run a check for new
  versions above the project.

Add "Test check" button to add/edit project page to allow users to test
changes before submitting.

Update `check_project_release`, `create_project` and `edit_project` methods to allow dry_run.

Closes fedora-infra#491

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Nov 4, 2020
This adds API v2 versions target with GET and POST methods.
* GET method allows user to get versions that are currently available on the project.
* POST allows user to apply temporary changes and run a check for new
  versions above the project.

Add "Test check" button to add/edit project page to allow users to test
changes before submitting.

Update `check_project_release`, `create_project` and `edit_project` methods to allow dry_run.

Closes fedora-infra#491

Signed-off-by: Michal Konečný <[email protected]>
@Zlopez Zlopez mentioned this issue Nov 4, 2020
Zlopez added a commit to Zlopez/anitya that referenced this issue Nov 4, 2020
This adds API v2 versions target with GET and POST methods.
* GET method allows user to get versions that are currently available on the project.
* POST allows user to apply temporary changes and run a check for new
  versions above the project.

Add "Test check" button to add/edit project page to allow users to test
changes before submitting.

Update `check_project_release`, `create_project` and `edit_project` methods to allow dry_run.

Closes fedora-infra#491

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit that referenced this issue Nov 4, 2020
This adds API v2 versions target with GET and POST methods.
* GET method allows user to get versions that are currently available on the project.
* POST allows user to apply temporary changes and run a check for new
  versions above the project.

Add "Test check" button to add/edit project page to allow users to test
changes before submitting.

Update `check_project_release`, `create_project` and `edit_project` methods to allow dry_run.

Closes #491

Signed-off-by: Michal Konečný <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
groomed Medium Priority This ticket has a medium priority type.feature New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants