Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub backend seems to regularly issue 403s #790

Closed
changlinli opened this issue Jun 15, 2019 · 3 comments · Fixed by #815
Closed

GitHub backend seems to regularly issue 403s #790

changlinli opened this issue Jun 15, 2019 · 3 comments · Fixed by #815

Comments

@changlinli
Copy link

I feel like I've seen this a couple of times, but I'm getting the following:

image

Maybe some sort of rate limiting by GitHub? I imagine it's probably transient since so many projects have GitHub backends, but it might be worth looking into so GitHub doesn't block Anitya.

@changlinli
Copy link
Author

Hmmm... okay that one had other issues (namely the version check URL is incorrect and yet it seems version checks worked anyway which is odd). Here's an example of one with a correct version check URL

image

@Zlopez
Copy link
Contributor

Zlopez commented Jun 16, 2019

This is definitely related to Github ratelimit. I have few feature requests (#589, #733) already created that should help with this.

@Zlopez Zlopez added this to the 0.17.0 milestone Jul 22, 2019
@Zlopez
Copy link
Contributor

Zlopez commented Jul 22, 2019

From https://developer.github.com/v3/#rate-limiting I noticed that 403 is returned when the limit is already reached, which probably happens a lot.
We need to handle 403 on GitHub backend as RateLimitException instead of AnityaPluginException.

@Zlopez Zlopez added the easyfix label Jul 22, 2019
Zlopez added a commit to Zlopez/anitya that referenced this issue Aug 23, 2019
Zlopez added a commit to Zlopez/anitya that referenced this issue Aug 23, 2019
Zlopez added a commit that referenced this issue Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants