Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counter for number of failed check to project #829

Closed
Zlopez opened this issue Sep 5, 2019 · 0 comments
Closed

Add counter for number of failed check to project #829

Zlopez opened this issue Sep 5, 2019 · 0 comments
Assignees
Labels
Medium Priority This ticket has a medium priority type.feature New feature
Milestone

Comments

@Zlopez
Copy link
Contributor

Zlopez commented Sep 5, 2019

Description

Currently we only watching error output from last check, which is enough, but it will be nice to know how long this is happening. So I want to introduce following enhancements:

  1. Add counter to project, which will track number of failed checks and will be reset to 0, when project is successfully checked
  2. Add option to search for project based on the number of failures (this will probably need db index)
  3. (Optionally) Remove projects, which are failing for long time (could be configurable amount of failures) and didn't retrieved any version yet

Requirements

We need to change how no new version is announced. We currently announcing is as AnityaException, which is considered as error.
We should make difference between No version found and No new version found, it could look similar, but:

  • No version found could mean that there is no version on the page we are checking, regex is no longer matching anything (most of the backends are using regex for version matching), this could mean that page no longer exists or it was edited.
  • No new version found means that we are still see some version, but no new was found. This shouldn't be an error, this just means, that project didn't released any new version. This should be much easier to recognize with Add If-Modified-Since field to call URL header #778 merged.

How this will make Anitya better

Anitya currently contains plenty of projects, which can't be checked because the site no longer exists, project is incorrectly set up, the page has different content etc. This enhancement will help with identifying and possibly removing those projects.

@Zlopez Zlopez added type.feature New feature Medium Priority This ticket has a medium priority labels Sep 5, 2019
@Zlopez Zlopez added this to the 0.18.0 milestone Oct 15, 2019
@Zlopez Zlopez self-assigned this Dec 17, 2019
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 17, 2019
This adds error counter to project, which is incremented each time a
error happens when checking for new version. Error counter is reset to
0, when succesful check is done.

This also introduces GUI changes that allows users to see the error
counter on each project and option to find the projects, which are
failing most.

This will help identify problematic projects.

Implements part of fedora-infra#829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 18, 2019
New configurable field is introduced `error_threshold`. When project
reaches this threshold and didn't retrieved any version, it is
automatically deleted.

This will remove projects, that are incorrectly set up.

Implements optional part of fedora-infra#829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 19, 2019
This adds error counter to project, which is incremented each time a
error happens when checking for new version. Error counter is reset to
0, when succesful check is done.

This also introduces GUI changes that allows users to see the error
counter on each project and option to find the projects, which are
failing most.

This will help identify problematic projects.

Implements part of fedora-infra#829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 19, 2019
This adds error counter to project, which is incremented each time a
error happens when checking for new version. Error counter is reset to
0, when succesful check is done.

This also introduces GUI changes that allows users to see the error
counter on each project and option to find the projects, which are
failing most.

This will help identify problematic projects.

Implements part of fedora-infra#829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 19, 2019
New configurable field is introduced `error_threshold`. When project
reaches this threshold and didn't retrieved any version, it is
automatically deleted.

This will remove projects, that are incorrectly set up.

Implements optional part of fedora-infra#829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 19, 2019
New configurable field is introduced `error_threshold`. When project
reaches this threshold and didn't retrieved any version, it is
automatically deleted.

This will remove projects, that are incorrectly set up.

Implements optional part of fedora-infra#829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 19, 2019
New configurable field is introduced `error_threshold`. When project
reaches this threshold and didn't retrieved any version, it is
automatically deleted.

This will remove projects, that are incorrectly set up.

Implements optional part of fedora-infra#829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 19, 2019
New configurable field is introduced `error_threshold`. When project
reaches this threshold and didn't retrieved any version, it is
automatically deleted.

This will remove projects, that are incorrectly set up.

Implements optional part of fedora-infra#829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Jan 6, 2020
This adds error counter to project, which is incremented each time a
error happens when checking for new version. Error counter is reset to
0, when succesful check is done.

This also introduces GUI changes that allows users to see the error
counter on each project and option to find the projects, which are
failing most.

This will help identify problematic projects.

Implements part of fedora-infra#829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit to Zlopez/anitya that referenced this issue Jan 6, 2020
This adds error counter to project, which is incremented each time a
error happens when checking for new version. Error counter is reset to
0, when succesful check is done.

This also introduces GUI changes that allows users to see the error
counter on each project and option to find the projects, which are
failing most.

This will help identify problematic projects.

Implements part of fedora-infra#829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit that referenced this issue Jan 8, 2020
This adds error counter to project, which is incremented each time a
error happens when checking for new version. Error counter is reset to
0, when succesful check is done.

This also introduces GUI changes that allows users to see the error
counter on each project and option to find the projects, which are
failing most.

This will help identify problematic projects.

Implements part of #829

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit that referenced this issue Jan 8, 2020
New configurable field is introduced `error_threshold`. When project
reaches this threshold and didn't retrieved any version, it is
automatically deleted.

This will remove projects, that are incorrectly set up.

Implements optional part of #829

Signed-off-by: Michal Konečný <[email protected]>
@Zlopez Zlopez closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium Priority This ticket has a medium priority type.feature New feature
Projects
None yet
Development

No branches or pull requests

1 participant