Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub response 403 doesn't have ratelimit reset time #832

Closed
Zlopez opened this issue Sep 5, 2019 · 0 comments · Fixed by #834
Closed

GitHub response 403 doesn't have ratelimit reset time #832

Zlopez opened this issue Sep 5, 2019 · 0 comments · Fixed by #834
Labels

Comments

@Zlopez
Copy link
Contributor

Zlopez commented Sep 5, 2019

Currently we are expecting that GitHub response will always contain reset time for ratelimit, which isn't true when GitHub returns 403.

There are several options to deal with this:

  • Save reset time to somewhere where we could retrieve it later (global variable in anitya.lib.backends.github looks like quick solution)
  • Don't save it, check_service has it anyway, so it will know when to check the projects again, just raise RateLimitException without time.
@Zlopez Zlopez added the type.bug label Sep 5, 2019
Zlopez added a commit to Zlopez/anitya that referenced this issue Sep 5, 2019
Zlopez added a commit that referenced this issue Sep 6, 2019
Fixes #832

Signed-off-by: Michal Konečný <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant