Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Internal Server Error" while adding new project #845

Closed
abitrolly opened this issue Oct 12, 2019 · 10 comments · Fixed by #846
Closed

"Internal Server Error" while adding new project #845

abitrolly opened this issue Oct 12, 2019 · 10 comments · Fixed by #846
Labels

Comments

@abitrolly
Copy link
Contributor

I am trying to add https://github.com/watchexec/watchexec

image

This submission fails with internal server error.

@abitrolly
Copy link
Contributor Author

abitrolly commented Oct 12, 2019

The project is created https://release-monitoring.org/project/27539/ but it is not fetching versions as expected.

image

@abitrolly
Copy link
Contributor Author

The error seems to be caused by checking releases on submit.

image

@Zlopez
Copy link
Contributor

Zlopez commented Oct 14, 2019

This issue is caused by semantic versioning scheme, I will look at it more closely to find what exactly is causing this, for now you can switch to rpm versioning, which is working.

@Zlopez
Copy link
Contributor

Zlopez commented Oct 14, 2019

I looked at it more closely and now I knew, what is going wrong, you checked, that you want to watch releases, which is fine, but releases aren't using semantic versioning at all, they are using strange names. This is why the check for versions is crashing.
I will fix the crash and add some nice error message, but I can't do anything with the release names like "1.10.3: a new man", but probably I can use tag from which the version is created instead of name.

Zlopez added a commit to Zlopez/anitya that referenced this issue Oct 14, 2019
Because GitHub allows name of the release to be anything. It will be
better to use tags associated with the releases instead of using the
release names.

Fixes fedora-infra#845

Signed-off-by: Michal Konečný <[email protected]>
@abitrolly
Copy link
Contributor Author

Nice error message will definitely help.

If the interface could query tags without reloading that page, and show which were ok and which were failed - that will be helpful too.

@Zlopez
Copy link
Contributor

Zlopez commented Oct 14, 2019

This will be nice enhancement for Anitya, but it needs changes in how the checking is handled right now. It either recover versions or not. We should do some validations of the retrieved versions before working with it for this to work.

@abitrolly
Copy link
Contributor Author

Does checking occur in a separate job queue and message passed as a result doesn't contain necessary details?

@Zlopez
Copy link
Contributor

Zlopez commented Oct 14, 2019

Checking is done in separate thread on web interface and there is service running as separate pod which does the heavy work in check. The message is sent after new version is discovered when checking.

@abitrolly
Copy link
Contributor Author

Where is the place to modify the message passed from service to web thread, to include the tags discovered?

@Zlopez
Copy link
Contributor

Zlopez commented Oct 15, 2019

There is no message communication between those service and web. Both of them only communicate with database when changing project or adding discovered version.

Zlopez added a commit that referenced this issue Oct 21, 2019
Because GitHub allows name of the release to be anything. It will be
better to use tags associated with the releases instead of using the
release names.

Fixes #845

Signed-off-by: Michal Konečný <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants