Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip whitespaces from version when removing prefix #866

Closed
Zlopez opened this issue Dec 18, 2019 · 0 comments · Fixed by #869
Closed

Strip whitespaces from version when removing prefix #866

Zlopez opened this issue Dec 18, 2019 · 0 comments · Fixed by #869
Labels
easyfix Medium Priority This ticket has a medium priority type.feature New feature

Comments

@Zlopez
Copy link
Contributor

Zlopez commented Dec 18, 2019

Description

When removing prefix from version for version compare by specified version scheme, we should first remove any remaining whitespace, otherwise the versions could be compared wrongly.

Requirements

Adjust parse method in anitya.lib.versions.base to strip the version after removing every prefix from it.

How this will make Anitya better

This will prevent getting wrong sort order even when everything looks OK.
@Zlopez Zlopez added type.feature New feature Medium Priority This ticket has a medium priority easyfix labels Dec 18, 2019
Zlopez added a commit to Zlopez/anitya that referenced this issue Dec 19, 2019
@Zlopez
Remove whitespace when removing prefixes
c76f660 
Closes fedora-infra#866

Signed-off-by: Michal Konečný <[email protected]>
@Zlopez Zlopez mentioned this issue Dec 19, 2019
Merged
Zlopez added a commit that referenced this issue Jan 8, 2020
@Zlopez
Remove whitespace when removing prefixes
560fab9 
Closes #866

Signed-off-by: Michal Konečný <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easyfix Medium Priority This ticket has a medium priority type.feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove whitespace when removing prefixes Zlopez/anitya
1 participant
@Zlopez