Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distro search is broken #876

Closed
abitrolly opened this issue Jan 1, 2020 · 4 comments · Fixed by #883
Closed

Distro search is broken #876

abitrolly opened this issue Jan 1, 2020 · 4 comments · Fixed by #883
Labels

Comments

@abitrolly
Copy link
Contributor

https://release-monitoring.org/distro/Alpine/search/?pattern=acpi gives 500 Internal Error.

The fix is the same as https://github.com/release-monitoring/anitya/pull/757/files but I am curious why the distro relationship doesn't work here?

https://github.com/release-monitoring/anitya/blob/299701f9865f3833cd4eaa4413effa32a5b0996a/anitya/db/models.py#L156-L158

@abitrolly
Copy link
Contributor Author

@Zlopez
Copy link
Contributor

Zlopez commented Jan 6, 2020

@abitrolly You are right, there should be Packages.distro_name in the search method.

@Zlopez Zlopez added the type.bug label Jan 6, 2020
@abitrolly
Copy link
Contributor Author

@Zlopez why distro relationship didn't work?

@Zlopez
Copy link
Contributor

Zlopez commented Jan 6, 2020

I didn't tried it, I just looked at the code and this looks like the cause of the issue. I will try to debug this later.

Zlopez added a commit to Zlopez/anitya that referenced this issue Jan 9, 2020
Use distro_name instead of distro relationship on package, because the
later caused error 500.
Limit project search by mapping to distro if available. Otherwise we
will end up with projects from another distros.

Fixes fedora-infra#876

Signed-off-by: Michal Konečný <[email protected]>
Zlopez added a commit that referenced this issue Jan 13, 2020
Use distro_name instead of distro relationship on package, because the
later caused error 500.
Limit project search by mapping to distro if available. Otherwise we
will end up with projects from another distros.

Fixes #876

Signed-off-by: Michal Konečný <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants